On Wed, Mar 05, 2025 at 07:26:45PM +0800, Yongbang Shi wrote: > From: Baihan Li <libaihan@xxxxxxxxxx> > > DP controller can support generating a color bar signal over the > DisplayPort interface. This can be useful to check for possible DDR > or GPU problems, as the signal generator resides completely in the DP > block. Add debugfs file that controls colorbar generator. > > echo: config the color bar register to display > cat: print the color bar configuration > > Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx> > Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx> > --- > ChangeLog: > v3 -> v4: > - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. > v2 -> v3: > - rewrite the commit log, suggested by Dmitry Baryshkov. > - move colorbar debugfs entry to this patch, suggested by Dmitry Baryshkov. > - change binary format to integer format, suggested by Dmitry Baryshkov. > v1 -> v2: > - add colorbar introduction in commit, suggested by Dmitry Baryshkov. > - splittting colorbar and debugfs in different patches, suggested by Dmitry Baryshkov. > - deleting edid decoder and its debugfs, suggested by Dmitry Baryshkov. > - using debugfs_init() callback, suggested by Dmitry Baryshkov. > --- > drivers/gpu/drm/hisilicon/hibmc/Makefile | 3 +- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 43 ++++++++ > drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 29 +++++ > drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 3 + > .../drm/hisilicon/hibmc/hibmc_drm_debugfs.c | 104 ++++++++++++++++++ > .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 1 + > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 + > 7 files changed, 184 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_debugfs.c > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry