On Tue, 04 Mar 2025 12:10:44 +0100 Maxime Ripard <mripard@xxxxxxxxxx> wrote: > The drm_bridge structure contains an encoder pointer that is widely used > by bridge drivers. This pattern is largely documented as deprecated in > other KMS entities for atomic drivers. > > However, one of the main use of that pointer is done in attach to just > call drm_bridge_attach on the next bridge to add it to the bridge list. > While this dereferences the bridge->encoder pointer, it's effectively > the same encoder the bridge was being attached to. > > We can make it more explicit by adding the encoder the bridge is > attached to to the list of attach parameters. This also removes the need > to dereference bridge->encoder in most drivers. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> Tested-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
