On Mon, Mar 03, 2025 at 08:41:06PM +0100, Danilo Krummrich wrote: > On Mon, Mar 03, 2025 at 06:49:07PM +0100, Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > Date: Wed, 5 Apr 2023 18:38:54 +0200 > > > > The label “out_prevalid” was used to jump to another pointer check > > despite of the detail in the implementation of the function > > “nouveau_gem_ioctl_pushbuf” that it was determined already in one case > > that the corresponding variable contained an error pointer > > because of a failed call of the function “u_memcpya”. > > > > Thus use an additional label. > > > > This issue was detected by using the Coccinelle software. > > > > Fixes: 2be65641642e ("drm/nouveau: fix relocations applying logic and a double-free") > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > I'm not entirely sure, but I remember that we had this discussion already. > > Can you please send patches from the same address as indicated by your SoB? This is not a bug fix so it shouldn't have a Fixes tag. regards, dan carpenter