On 2/21/25 10:11, Krzysztof Kozlowski wrote: > On Wed, Feb 19, 2025 at 03:02:27PM +0100, Michal Wilczynski wrote: >> Add a mandatory reset property for the TH1520 VO clock controller that >> handles the GPU clocks. This reset line controls the GPU CLKGEN reset, >> which is required for proper GPU clock operation. >> >> The reset property is only required for the "thead,th1520-clk-vo" >> compatible, as it specifically handles the GPU-related clocks. >> >> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> >> --- >> .../bindings/clock/thead,th1520-clk-ap.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml >> index 9d058c00ab3d..6ea8202718d0 100644 >> --- a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml >> +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml >> @@ -40,6 +40,12 @@ properties: >> (integer PLL) typically running at 792 MHz (FOUTPOSTDIV), with >> a maximum FOUTVCO of 2376 MHz. >> >> + resets: >> + maxItems: 1 >> + description: >> + Required for "thead,th1520-clk-vo". This reset line controls the > > You just added the compatible in other patch, so are you saying you > added knowingly incomplete code? > > No, this must be squashed. > >> + GPU CLKGEN reset which is required for proper GPU clock operation. >> + >> "#clock-cells": >> const: 1 >> description: >> @@ -51,6 +57,16 @@ required: >> - clocks >> - "#clock-cells" >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: thead,th1520-clk-vo >> + then: >> + required: >> + - resets > > else: > ? What's there? Also reset or no? If the else: case the reset is not required, as it's only required in the th1520clk-vo, so there is no need for else:. > > Best regards, > Krzysztof > >
