Hi Andy, Am Dienstag, 18. Februar 2025, 12:27:34 MEZ schrieb Andy Yan: > From: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > > In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports, > so make sure all VP find it's suitable primary plane, then register the > remain windows as overlay plane will make code easier. > > Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > Tested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> # on RK3568 > Tested-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > > --- patches 7-9 look good to go, but ... this needs a rebase to adapt to "drm/rockchip: vop2: Consistently use dev_err_probe()" [0] [0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/b06d1ef3355571383cdb463cf0195b7a02efdfbf > - if (win->type == DRM_PLANE_TYPE_PRIMARY) { > - vp = find_vp_without_primary(vop2); > - if (vp) { > + if (vop2_is_mirror_win(win)) > + continue; > + > + if (win->type == DRM_PLANE_TYPE_PRIMARY) { > possible_crtcs = BIT(nvp); > vp->primary_plane = win; > + ret = vop2_plane_init(vop2, win, possible_crtcs); > + if (ret) { > + drm_err(vop2->drm, "failed to init primary plane %s: %d\n", > + win->data->name, ret); should also use dev_err_probe Heiko
