On Tue, Feb 25, 2025 at 05:43:59PM +0100, Maxime Ripard wrote: > The Cadence DSI driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortunately, the CRTC pointer is now provided > in the bridge state, so we can move to atomic callbacks and drop that > deprecated pointer usage. Here and in the next several patches: commit message in no longer accurate. You've dropped the drm_bridge_state.crtc change. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> > --- > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 31 ++++++++++++++++++-------- > 1 file changed, 22 insertions(+), 9 deletions(-) > [...] > - mode = &bridge->encoder->crtc->state->adjusted_mode; > + connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); > + conn_state = drm_atomic_get_new_connector_state(state, connector); > + crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc); > + mode = &crtc_state->adjusted_mode; > nlanes = output->dev->lanes; > > WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false)); > > cdns_dsi_hs_init(dsi); -- With best wishes Dmitry
