On 2025-02-19 22:35, André Almeida wrote: > After a GPU reset happens, the driver creates a coredump file. However, > the user might not be aware of it. Log the file creation the user can > find more information about the device and add the file to bug reports. > This is similar to what the xe driver does. > > Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c > index 824f9da5b6ce..7b50741dc097 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c > @@ -364,5 +364,9 @@ void amdgpu_coredump(struct amdgpu_device *adev, bool skip_vram_check, > > dev_coredumpm(dev->dev, THIS_MODULE, coredump, 0, GFP_NOWAIT, > amdgpu_devcoredump_read, amdgpu_devcoredump_free); > + > + drm_info(dev, "AMDGPU device coredump file has been created\n"); > + drm_info(dev, "Check your /sys/class/drm/card%d/device/devcoredump/data\n", > + dev->primary->index); > } > #endif Maybe this should be done in dev_coredumpm instead of in the driver? Could make it a single line: drm_info(dev, "Device core dump created in /sys/class/drm/card%d/device/devcoredump/data\n", dev->primary->index); (AFAICT drm_info prints the driver name twice already, no need for a third time :) -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast
