Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Looking at the header files, it looks like doing cpu_to_le32 on that variable and doing le32_to_cpu will actually reverse the order twice, on big endian systems, thus technically all way would not swap the order at all.
> 
> I'm not really sure how to manage the sparse warnings here.



Not sure whether the maintainers would like it, but we can do something like this:

	case 'l’:
#ifdef __LITTLE_ENDIAN
		val = orig;
#else
		orig = swab32(orig);
		val = orig;
#endif
		break;

	case 'b’:
#ifdef __LITTLE_ENDIAN
		orig = swab32(orig);
		val = orig;
#else
		val = orig;
#endif
		break;




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux