On Sat, Feb 22, 2025 at 10:50:58AM +0800, Yongbang Shi wrote:
> From: Baihan Li <libaihan@xxxxxxxxxx>
>
> Add registering drm_aux and use it to get connector edid with drm
> functions. Add ddc channel in connector initialization to put drm_aux
> in drm_connector. And also add detect callback to detect connector
> befored call connector_get_modes.
>
> Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx>
> Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx>
> ---
> ChangeLog:
> v2 -> v3:
> - Capitalized EDID and AUX, suggested by Dmitry Baryshkov.
> v1 -> v2:
> - deleting type conversion, suggested by Dmitry Baryshkov.
> - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), suggested by Dmitry Baryshkov.
> ---
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 3 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 33 ++++++++++++++++---
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 5 +++
> 3 files changed, 35 insertions(+), 6 deletions(-)
>
>
> static const struct drm_connector_helper_funcs hibmc_dp_conn_helper_funcs = {
> .get_modes = hibmc_dp_connector_get_modes,
> + .detect_ctx = drm_connector_helper_detect_from_ddc,
I think a proper .detect callback should be reading sink_count. Most
likely it will work though.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> };
>
--
With best wishes
Dmitry
