On Thu, Feb 20, 2025 at 05:20:48PM +0800, Shixiong Ou wrote: > > 在 2025/2/20 17:12, Maxime Ripard 写道: > > On Thu, Feb 20, 2025 at 04:53:58PM +0800,oushixiong1025@xxxxxxx wrote: > > > From: Shixiong Ou<oushixiong@xxxxxxxxxx> > > > > > > [WHY] If the call to sysfs_create_group() fails, there is > > > no need to call function sysfs_remove_group(). > > > > > > [HOW] Add a condition check before removing sysfs attribute. > > > > > > Signed-off-by: Shixiong Ou<oushixiong@xxxxxxxxxx> > > What are you trying to fix exactly? AFAIK, there's no code path that > > calls komeda_dev_destroy() after komeda_dev_create() has failed. > > |if calling |||sysfs_create_group() fails, it will go to lable > 'err_cleanup:', and it will call |komeda_dev_destroy() laterly. Ah, right. Then that's what you should fix. Maxime
Attachment:
signature.asc
Description: PGP signature
