On Sun, 20 Oct 2024, at 3:11 AM, Dmitry Baryshkov wrote: > On Sun, Sep 29, 2024 at 10:04:33PM +1300, Ryan Walklin wrote: Hi Dmitry, thanks for reviewing, and apologies for the delay in replying. >> -enum sun8i_csc_mode { >> - SUN8I_CSC_MODE_OFF, >> - SUN8I_CSC_MODE_YUV2RGB, >> - SUN8I_CSC_MODE_YVU2RGB, >> +enum format_type { > > enum sun8i_format_type, unless there is a strong reason to name it > otherwise. No problem, will make that change. Regards, Ryan