On 13.02.2025 5:41 PM, Thomas Zimmermann wrote: > Hi > > Am 13.02.25 um 17:35 schrieb Abel Vesa: >> On 24-12-19 23:36:56, Konrad Dybcio wrote: >>> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >>> >>> Log the version for informational purposes, such as for keeping track >>> of possible GMU fw-related failures in crash / CI logs. >>> >>> Intentionally not implemented on the if (gmu->legacy) codepath, as >>> these registers seem not to be used on there. >>> >>> Downstream additionally warns if the firmware version is too old for >>> a given GPU, but we already pair the binary to a given GPU, so let's >>> not go there at the moment. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >>> --- [...] >> So maybe DRM_INFO_ONCE instead ? > > drm_dbg() seems appropriate. Most of the time, firmware versions are not interesting. Unfortunately, in our case they are, given users source them from all kinds of places.. Konrad
