On Thu, Feb 13, 2025 at 02:59:25PM +0100, Louis Chauvet wrote:
> On 11/02/25 - 12:09, José Expósito wrote:
> > Creating a new vkms_config structure will be more complex once we
> > start adding more options.
> >
> > Extract the vkms_config structure to its own header and source files
> > and add functions to create and delete a vkms_config and to initialize
> > debugfs.
> >
> > Refactor, no functional changes.
> >
> > Co-developed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> > Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> > Signed-off-by: José Expósito <jose.exposito89@xxxxxxxxx>
>
> This does not build in module, can you add this in the next version?
Interesting. I have "CONFIG_DRM_VKMS=m" in my config and it compiles here.
What do you have as module? CONFIG_DRM_VKMS_KUNIT_TESTS=m?
I'll rebuild every patch to make sure there are no errors.
Thanks for the heads up!
Jose
> diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
> index 152b2ecd6aef..42caa421876e 100644
> --- a/drivers/gpu/drm/vkms/vkms_config.c
> +++ b/drivers/gpu/drm/vkms/vkms_config.c
> @@ -4,6 +4,7 @@
>
> #include <drm/drm_print.h>
> #include <drm/drm_debugfs.h>
> +#include <kunit/visibility.h>
>
> #include "vkms_config.h"
>
> @@ -17,11 +18,13 @@ struct vkms_config *vkms_config_create(void)
>
> return config;
> }
> +EXPORT_SYMBOL_IF_KUNIT(vkms_config_create);
>
> void vkms_config_destroy(struct vkms_config *config)
> {
> kfree(config);
> }
> +EXPORT_SYMBOL_IF_KUNIT(vkms_config_destroy);
>
> static int vkms_config_show(struct seq_file *m, void *data)
> {
>
> With this:
>
> Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
