Re: [PATCH] drm/tests: Drop drm_kunit_helper_acquire_ctx_alloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 06, 2025 at 05:05:48PM +0100, Maxime Ripard wrote:
> lockdep complains when a lock is released in a separate function the
> lock is taken in, and it's even worse in the kunit case since the kunit
> actions run in a separate thread.
> 
> This means that drm_kunit_helper_acquire_ctx_alloc() just cannot work as
> it's supposed to, so let's just get rid of it.
> 
> Suggested-by: Simona Vetter <simona.vetter@xxxxxxxx>
> Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/tests/drm_atomic_state_test.c |  24 +-
>  .../drm/tests/drm_hdmi_state_helper_test.c    | 242 +++++++++++-------
>  drivers/gpu/drm/tests/drm_kunit_helpers.c     |  41 ---
>  .../gpu/drm/vc4/tests/vc4_test_pv_muxing.c    |  46 ++--
>  include/drm/drm_kunit_helpers.h               |   2 -
>  5 files changed, 184 insertions(+), 171 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

-- 
With best wishes
Dmitry



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux