On Thu, Feb 06, 2025 at 07:14:22PM +0100, Luca Ceresoli wrote: > Having an DRM_MODE_CONNECTOR_Unknown connector type is consuidered bad, and considered > drm_panel_bridge_add_typed() and derivatives are deprecated for this. > > drm_panel_init() won't prevent initializing a panel with a > DRM_MODE_CONNECTOR_Unknown connector type. Luckily there are no in-tree > users doing it, so take this as an opportinuty to document a valid > connector type must be passed. > > Returning an error if this rule is violated is not possible because > drm_panel_init() is a void function. Add at least a warning to make any > violations noticeable, especially to non-upstream drivers. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> > > --- > > This patch was added in v6. > --- > drivers/gpu/drm/bridge/panel.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
