On Wed, Feb 05, 2025 at 12:52:52PM +0100, Krzysztof Kozlowski wrote: > On 05/02/2025 12:50, Harikrishna Shenoy wrote: > > From: Rahul T R <r-ravikumar@xxxxxx> > > > > The mhdp bridge can work without its HPD pin hooked up to the connector, > > but the current bridge driver throws an error when hpd line is not > > connected to the connector. For such cases, we need an indication for > > no-hpd, using which we can bypass the hpd detection and instead use the > > auxiliary channels connected to the DP connector to confirm the > > connection. > > So add no-hpd property to the bindings, to disable hpd when not > > connected or unusable due to DP0-HPD not connected to correct HPD > > pin on SOC like in case of J721S2. > > > > Signed-off-by: Rahul T R <r-ravikumar@xxxxxx> > > Why are you sending over and over the same? You already got feedback. > Then you send v2. You got the same feedback. > > Now you send v3? > > So the same feedback, but this time: NAK Krzysztof's email forced me to take a look at the actual boards that you are trying to enable. I couldn't stop by notice that the HPD signal _is_ connected to a GPIO pin. Please stop hacking the bridge driver and use the tools that are already provided to you: add the HPD pin to the dp-controller device node. And then fix any possible issues coming from the bridge driver not being able to handle HPD signals being delivered by the DRM framework via the .hpd_notify() callback. TL;DR: also a NAK from my side, add HPD gpio to dp-controller. -- With best wishes Dmitry
