On Tue, Feb 04, 2025 at 04:10:37PM +0800, Pin-yen Lin wrote: > Hi Hermes, > > On Tue, Feb 4, 2025 at 11:49 AM <Hermes.Wu@xxxxxxxxxx> wrote: > > > > Hi > > > > > >-----Original Message----- > > >From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > >Sent: Tuesday, February 4, 2025 1:28 AM > > >To: Hermes Wu (吳佳宏) <Hermes.Wu@xxxxxxxxxx> > > >Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Neil Armstrong <neil.armstrong@xxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>; Jonas Karlman <jonas@xxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>; Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter <simona@xxxxxxxx>; treapking@xxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Pet Weng (翁玉芬) <Pet.Weng@xxxxxxxxxx>; Kenneth Hung (洪家倫) <Kenneth.Hung@xxxxxxxxxx> > > >Subject: Re: [PATCH v2] drm/bridge: it6505: support hdmi_codec_ops for audio stream setup > > > > > >On Mon, Feb 03, 2025 at 02:04:30PM +0800, Hermes Wu via B4 Relay wrote: > > >> From: Hermes Wu <Hermes.wu@xxxxxxxxxx> > > >> > > >> For supporting audio form I2S to DP audio data sub stream. > > >> Add hdmi_audio callbacks to drm_bridge_funcs for the HDMI codec > > >> framework. The DRM_BRIDGE_OP_HDMI flag in bridge.ops must be set, and > > >> hdmi_write_infoframe and hdmi_clear_infoframe are necessary for the > > >> drm_bridge_connector to enable the HDMI codec. > > > > > >Please split this into two commits: one adding OP_HDMI, second one adding audio support. > > > > This will need send patches with cover letter, should I keep patch version or reset it? > > I would bump to v3 in this case. Definitely. -- With best wishes Dmitry
