Re: [PATCH v3 2/2] drm/tests: Add test for drm_atomic_helper_commit_modeset_disables()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 12, 2024 at 12:50:35AM +0200, Dmitry Baryshkov wrote:
> On Wed, Dec 11, 2024 at 01:18:43PM -0800, Jessica Zhang wrote:
> > Add a subtest to check that modeset is called when the connector is
> > changed
> > 
> > Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>
> > ---
> > Changes in v3:
> > - Use BUILD_BUG_ON to check connectors and encoders array sizes (Dmitry)
> > - Renamed functions to be more test-specific (Dmitry)
> > - Added comment description for test (Dmitry)
> > - Return get_modes_fixed() directly within the encoder get_modes
> >   function (Dmitry)
> > - Move drm_connector local variable declaration to top of function
> >   (Dmitry)
> > - Changed drm_test_modeset() to a more descriptive name
> > ---
> >  drivers/gpu/drm/tests/Makefile                |   1 +
> >  drivers/gpu/drm/tests/drm_atomic_state_test.c | 244 ++++++++++++++++++++++++++
> >  2 files changed, 245 insertions(+)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Pretty sure this blows up with CONFIG_DEBUG_WW_MUTEX_SLOWPATH enabled.
Seems to generally be an issue with our kms kunit tests, so probably also
something we want to fix in CI.

Plus a pile of work to sort this out I fear :-/
-Sima
-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux