On Wed, Jan 29, 2025 at 03:21:54PM +0100, Maxime Ripard wrote: > Some tests have the drm pointer assigned multiple times to the same > value. Drop the redundant assignments. > > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> Reviewed-by: Simona Vetter <simona.vetter@xxxxxxxx> > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > index e814b538c46c4d342604436beca64ac0bdb31526..32e0477deb45c1481a7d23bb6e6a74de52845d1c 100644 > --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > @@ -479,11 +479,10 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_vic_1(struct kunit *test) > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); > > mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); > KUNIT_ASSERT_NOT_NULL(test, mode); > > - drm = &priv->drm; > crtc = priv->crtc; > ret = light_up_connector(test, drm, crtc, conn, mode, ctx); > KUNIT_ASSERT_EQ(test, ret, 0); > > state = drm_kunit_helper_atomic_state_alloc(test, drm, ctx); > @@ -593,11 +592,10 @@ static void drm_test_check_broadcast_rgb_full_cea_mode_vic_1(struct kunit *test) > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); > > mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); > KUNIT_ASSERT_NOT_NULL(test, mode); > > - drm = &priv->drm; > crtc = priv->crtc; > ret = light_up_connector(test, drm, crtc, conn, mode, ctx); > KUNIT_ASSERT_EQ(test, ret, 0); > > state = drm_kunit_helper_atomic_state_alloc(test, drm, ctx); > @@ -709,11 +707,10 @@ static void drm_test_check_broadcast_rgb_limited_cea_mode_vic_1(struct kunit *te > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); > > mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1); > KUNIT_ASSERT_NOT_NULL(test, mode); > > - drm = &priv->drm; > crtc = priv->crtc; > ret = light_up_connector(test, drm, crtc, conn, mode, ctx); > KUNIT_ASSERT_EQ(test, ret, 0); > > state = drm_kunit_helper_atomic_state_alloc(test, drm, ctx); > @@ -1311,11 +1308,10 @@ static void drm_test_check_output_bpc_format_vic_1(struct kunit *test) > * Thus, we have to calculate the rate by hand. > */ > rate = mode->clock * 1500; > KUNIT_ASSERT_LT(test, rate, info->max_tmds_clock * 1000); > > - drm = &priv->drm; > crtc = priv->crtc; > ret = light_up_connector(test, drm, crtc, conn, mode, ctx); > KUNIT_EXPECT_EQ(test, ret, 0); > > conn_state = conn->state; > > -- > 2.47.1 > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch