Re: [RFC PATCH 00/12] Deduplicate cfb/sys drawing fbops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Some notes regarding your patches:
> - please add dri-devel@xxxxxxxxxxxxxxxxxxxxx mailing list

Will do next time.

> - it seems you sent your patches manually.

Yes, I thought it will work after a bit of practice without mistakes. Sorry.

> - patch #2 is missing, and patches 1-5 have the same subject.

On that one I missed to delete the "Re:" prefix in the subject, but it
was there. And after the 5th I noticed that possibly the subject needs to
be changed as well. Also replies should have been on the first one not
always on the previous one.

> - When applying there are warnings:

Will retab and white space clean it next time. However I noticed that even
if I set up the e-mail client as advised it still removed single spaces in
diffs for unchanged empty lines.

> I suggest you make yourself familiar with "git-publish" (https://github.com/stefanha/git-publish).
> It's a great tool which helps a lot for sending patches.

That complicates things but it seems it's almost impossible to do it correctly
manually. Will look into it.

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux