On Tue, Jan 21, 2025 at 09:42:17AM -0500, Rodrigo Vivi wrote: > On Sat, Jan 18, 2025 at 06:47:27PM +0100, Michal Wajdeczko wrote: > > > > > > On 17.01.2025 22:57, Vinay Belgaumkar wrote: > > > Default SLPC power profile is Base(0). Power Saving mode(1) > > > has conservative up/down thresholds and is suitable for use with > > > apps that typically need to be power efficient. > > > > > > Selected power profile will be displayed in this format- > > > > > > $ cat slpc_power_profile > > > > > > [base] power_saving > > > > > > $ echo power_saving > slpc_power_profile > > > $ cat slpc_power_profile > > > > > > base [power_saving] > > > > > > > is that output aligned with the sysfs rules? from [1] > > Please help me to understand why that is against the rule? > > It is still ascii and it is one value per file. > > How is this different from: > > $ cat /sys/power/mem_sleep > [s2idle] shallow deep > > ?! Hi Michal, do you still see a problem here? Anything I might be missing? I'd like to get this patch merged soon Thanks, Rodrigo. > > > > > "Attributes should be ASCII text files, preferably with only one value > > per file. It is noted that it may not be efficient to contain only one > > value per file, so it is socially acceptable to express an array of > > values of the same type. > > > > Mixing types, expressing multiple lines of data, and doing fancy > > formatting of data is heavily frowned upon. Doing these things may get > > you publicly humiliated and your code rewritten without not" > > > > > > [1] https://www.kernel.org/doc/html/latest/filesystems/sysfs.html#attributes > >
