On 03/02/2025 13:40, Kaustabh Chakraborty wrote: > On 2025-02-03 07:54, Krzysztof Kozlowski wrote: >> On Mon, Feb 03, 2025 at 12:37:58AM +0530, Kaustabh Chakraborty wrote: >>> From: Sergey Lisov <sleirsgoevy@xxxxxxxxx> >>> >>> Add unique identifiers for exynos7870 clocks for every bank. It adds all >>> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and >>> CMU_PERI. >>> >>> Signed-off-by: Sergey Lisov <sleirsgoevy@xxxxxxxxx> >>> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> >>> --- >>> include/dt-bindings/clock/exynos7870.h | 324 +++++++++++++++++++++++++ >>> 1 file changed, 324 insertions(+) >> >> Look at git log - that's never a separate commit. > > Hmm, I see past examples which are mixed. > > 2ae5c2c3f8d586b709cf67efe94488be397d7544 > Exynos850 CMU (c. 2021). CMU definitions are in a separate commit. > > 591020a516720e9eba1c4b1748cb73b6748e445f > Exynos7885 CMU (c. 2021). CMU definitions are in a separate commit. > Huh, indeed, my mistake. Let's avoid that pattern, so binding headers are always part of bindings commit. Best regards, Krzysztof
