On Thu, 2025-01-30 at 17:43 -0500, Vivi, Rodrigo wrote: > On Tue, Jan 28, 2025 at 10:36:50AM -0800, Alan Previn wrote: alan:snip > > @@ -55,8 +55,7 @@ void xe_hw_engine_handle_irq(struct xe_hw_engine *hwe, u16 intr_vec); > > void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe); > > u32 xe_hw_engine_mask_per_class(struct xe_gt *gt, > > enum xe_engine_class engine_class); > > -struct xe_hw_engine_snapshot * > > -xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe, struct xe_exec_queue *q); > > +void xe_engine_snapshot_capture_for_queue(struct xe_exec_queue *q); > > here as well. please respect the name space. alan: my bad - will fix this (and the same in last patch). > > > void xe_hw_engine_snapshot_free(struct xe_hw_engine_snapshot *snapshot); > > void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drm_printer *p); > > void xe_hw_engine_print(struct xe_hw_engine *hwe, struct drm_printer *p); > > -- > > 2.34.1 > >