Hi Jocelyn
Am 27.01.25 um 15:26 schrieb Jocelyn Falempe:
On 24/01/2025 08:57, Thomas Zimmermann wrote:
Testing for support of widescreen modes mixes up various hardware
Gens. First branch by hardware Gen, then do specific tests for each
Gen. By default, widesscreen support is disabled.
Later patches will add more specific tests for each Gen.
I think it introduces a bit too much repeated code.
Maybe adding a small helper like this would help?
I'll add a helper here and for the code in patch 6
Best regards
Thomas
static bool ast_vgacrd0_support_wuxga(struct ast_device *ast) {
u8 vgacrd0;
vgacrd0 = ast_get_index_reg(ast, AST_IO_VGACRI, 0xd0);
return !(vgacrd0 & AST_IO_VGACRD0_VRAM_INIT_BY_BMC) ||
(vgacrd0 & AST_IO_VGACRD0_IKVM_WIDESCREEN));
}
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
