Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 24/01/2025 01:56, Sean Anderson wrote:
On 11/12/24 12:22, Sean Anderson wrote:
On 11/12/24 11:43, Laurent Pinchart wrote:
On Tue, Nov 12, 2024 at 09:41:58AM -0500, Sean Anderson wrote:
On 11/12/24 00:27, Laurent Pinchart wrote:
Hi Dan,

Thank you for the patch.

On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote:
We added some locking to this function, but accidentally forgot to unlock
if zynqmp_dp_mode_configure() failed.  Use a guard lock to fix it.

Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Sean, how about replacing all the mutex_lock()/mutex_unlock() calls
you've added in a7d5eeaa57d7 with guards ?

I have no objection to that.

Would you send a patch ? Otherwise I can do it.


I can send a patch, but it will not be for a week or two.

--Sean

Just following up on this; will the above patched be merged? I would
prefer to keep the bugfix and the conversion separate.

I'll push to drm-misc-fixes.

 Tomi




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux