Hi Doug, Your suggestion is very helpful to me, thank you. I confirmed the controller chips of these two panels, and it turned out that they use the HX83102 IC, so the correct approach is that I should add these two MIPI panels to the binding file/driver of the MIPI controller of HX83102.I would like to ask if I need to release a v5 version or resend a new email if I do this? Thank you again for taking the time out of your busy schedule to guide me. Doug Anderson <dianders@xxxxxxxxxxxx> 于2025年1月24日周五 01:46写道： > > Hi, > > On Wed, Jan 22, 2025 at 10:48 PM Langyan Ye > <yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > KINGDISPLAY KD110N11-51IE and STARRY 2082109QFH040022-50E are > > 10.95-inch WUXGA TFT LCD panels, which fits in nicely with the > > existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > > compatible with panel specific config. > > FWIW, this is still missing acting on a request that Krzysztof made. > Specifically, instead of the above wordy patch description, he > suggested a much simpler patch description that was just one sentence. > I could believe his suggestion may be difficult to understand if your > English isn't strong. He said [1]: > > > "Add a new compatible for foo bar panel ....". One sentence. Could be > > also one patch, not two patches > > Putting that more concretely, you'd want to change your patch > description in this case to: > > Add a new compatible for the panels KINGDISPLAY KD110N11-51IE and > STARRY 2082109QFH040022-50E. > > ...and that's it. > > Personally I wouldn't send a V5 just for this, but if Krzysztof > requests it strongly then I wouldn't object. > > That all being said, the part of the CL description that Krzysztof > wants you to trim is actually somewhat relevant to me if I am to give > a Reviewed-By tag. The agreement from DRM folks seemed to be that we > don't want to jam all MIPI panels into one bindings file and one > driver. The idea is that they should be organized by the controller > chip. For some history here, see [2] and all of the discussion in > response to a previous patch [3]. > > So the question is: do the new panels you're adding actually share the > same onboard MIPI controller as the other ones in this file? If not > then you _do_ need to spin your patch. If there's already some other > bindings file / driver for the MIPI controller in these panels then > you can add to that. If not then you'd need to add a new bindings file > and a new driver. > > [1] https://lore.kernel.org/r/9cf4efd5-cc4b-492c-a1f3-18a19ba7afeb@xxxxxxxxxx > [2] https://patchwork.freedesktop.org/patch/msgid/20240516072039.1287065-3-yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > [3] https://lore.kernel.org/all/20240410071439.2152588-1-yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
