Hi,
On Wed, Jan 22, 2025 at 1:30 AM Langyan Ye
<yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Hi Doug,
> Can you spare some time to help review it? Thanks a lot.
Sure. Let me see if I can figure out what's here:
v1:
- both panel patches got reviewed-by from Neil (nice!)
- wasn't well threaded
- After v4 was already out there, Dmitry replied to the cover letter
asking for bindings. You pointed him at v4, which doesn't seem to
exist?
v2:
- Krzysztof pointed out the lack of CCs
- Krzysztof pointed out broken threading.
- Krzysztof asked you to sort the bindings alphabetically ("k" for
"kingdisplay" doesn't come after "s" for "starry").
- Krzysztof suggested you make the bindings patch into one patch for
both panels.
- Krzysztof asked you to reword the bindings patch description to just
be one sentence: "Add a new compatible for foo bar panel ...".
v3:
- Seems to have proper threading.
- Seems to have better CCs.
- Krzysztof's other 3 requests were ignored. Krzysztof asked you to
make sure you follow all suggestions or say why you didn't.
- One of Krzysztof's replies to v3 seems to imply that you were still
missing some CCs, but I think he was mistaken here. The CCs look fine.
So summary is that you've already got a Reviewed-by for the two panel
patches but you need the bindings ones. It sounds like if you just
take Krzysztof's feedback and send a V4 that he'll likely give you a
Reviewed-by tag.
A few further notes:
- Usually you should make sure you don't send more than one version of
a patch series per day. It looks like you sent several previous
versions of your series in one day and that can overwhelm people.
- When you replied to your cover letter adding me, you didn't reply in
"Plain-Text" mode. That means anyone on the mailing lists (including
the archives) won't see it. Please use Plain-Text email when working
with the upstream mailing lists.
- The cover letter currently has the subject "Resend and include all
necessary To entries". The cover letter SUBJECT shouldn't be a version
history. The version history is contained in the cover letter body,
not the subject. The cover letter for all 3 versions should have had a
subject like "drm/panel: support kingdisplay-kd110n11-51ie and
starry-2082109qfh040022-50e MIPI-DSI panels"
-Doug
