On 2025-01-21 16:58:24, Luca Weiss wrote: > Hi Marijn, > > On Tue Jan 21, 2025 at 12:06 AM CET, Marijn Suijten wrote: > > Some SoCs such as SC7280 (used in the FairPhone 5) have only a single > > DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology > > (2 LM and 2 DSC for a single interface) make it impossible to use > > Display Stream Compression panels with mainline, which is exactly what's > > installed on the FairPhone 5. > > Nitpick, if you send another revision: s/FairPhone/Fairphone/ > > > > > By loosening the hardcoded `num_dsc = 2` to fall back to `num_dsc = > > 1` when the catalog only contains one entry, we can trivially support > > this phone and unblock further panel enablement on mainline. A few > > more supporting changes in this patch ensure hardcoded constants of 2 > > DSC encoders are replaced to count or read back the actual number of > > DSC hardware blocks that are enabled for the given virtual encoder. > > Likewise DSC_MODE_SPLIT_PANEL can no longer be unconditionally enabled. > > This unblocks panel enablement on upstream without any hacks on top. > Many thanks! > > Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> Thanks! I fixed the Fairphone capitalization typo but forgot to roll up your t-b (something about this being a long time ago and forgetting to run b4 trailers -u), but then the patch changed a little bit. - Marijn
