Hi Abhinav, On Wed, 22 Jan 2025 at 02:28, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: > > Stop declaring DPU_DSPP_PCC as a part of the DSPP features, use the > > presence of the PCC sblk to check whether PCC is present in the hardware > > or not. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_7_msm8996.h | 2 -- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 2 -- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_2_sdm660.h | 2 -- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_2_sm7150.h | 2 -- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_2_sc7180.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_3_sm6115.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 1 - > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 4 ---- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 -- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 2 +- > > 28 files changed, 1 insertion(+), 66 deletions(-) > > > > <snip> > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c > > index 0f5a74398e66642fba48c112db41ffc75ae2a79f..11fb1bc54fa92a5d9926addb437bc4b8f283723b 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c > > @@ -90,7 +90,7 @@ struct dpu_hw_dspp *dpu_hw_dspp_init(struct drm_device *dev, > > /* Assign ops */ > > c->idx = cfg->id; > > c->cap = cfg; > > - if (test_bit(DPU_DSPP_PCC, &c->cap->features)) > > + if (c->cap->sblk->pcc.base) > > c->ops.setup_pcc = dpu_setup_dspp_pcc; > > > > return c; > > > > Change LGTM, only one note (hopefully has already been taken into > consideration). There are two different versions of PCC, one with > version 0x10007 and the other 0x40000. > > If for some reason we need to distinguish these two versions while > programming, is the plan to use version to distinguish them? Because the > presence of PCC alone is not enough for using the "correct" PCC. Yes, we can either use mdss_ver or sblk->version to distinguish between those. -- With best wishes Dmitry
