Hi, On Tue, Jan 21, 2025 at 5:48 AM Tejas Vipin <tejasvipin76@xxxxxxxxx> wrote: > > @@ -136,12 +113,8 @@ static int s6e88a0_ams452ef01_prepare(struct drm_panel *panel) > static int s6e88a0_ams452ef01_unprepare(struct drm_panel *panel) > { > struct s6e88a0_ams452ef01 *ctx = to_s6e88a0_ams452ef01(panel); > - struct device *dev = &ctx->dsi->dev; > - int ret; > > - ret = s6e88a0_ams452ef01_off(ctx); > - if (ret < 0) > - dev_err(dev, "Failed to un-initialize panel: %d\n", ret); > + s6e88a0_ams452ef01_off(ctx); Can you change s6e88a0_ams452ef01_off() to return "void" instead of "int" since the caller (correctly) doesn't check the error code here now? With that: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>