On 20/01/25 - 17:23, José Expósito wrote:
> > A specific allocation for the CRTC is not strictly necessary at this
> > point, but in order to implement dynamic configuration of VKMS (configFS),
> > it will be easier to have one allocation per CRTC.
> >
> > Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>
> > Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> > ---
[...]
> > + /* Initialize the writeback component */
> > if (vkmsdev->config->writeback) {
> > - writeback = vkms_enable_writeback_connector(vkmsdev, crtc);
> > + writeback = vkms_enable_writeback_connector(vkmsdev, output);
> > if (writeback)
> > DRM_ERROR("Failed to init writeback connector\n");
> > }
>
> Hi Louis,
>
> Thanks for fixing this error condition.
>
> I have been working and running automated tests on top of this series and
> I haven't found any other issue.
>
> Reviewed-by: José Expósito <jose.exposito89@xxxxxxxxx>
Thanks a lot! I will merge this tomorrow.
What is your automated tests series?
I will also send tomorrow a new rebased iteration for:
- https://patchwork.freedesktop.org/series/140786/
- https://patchwork.freedesktop.org/series/133698/
- https://patchwork.freedesktop.org/patch/625883/
If someone can look on them and leave some reviews, I will be very happy
to apply them!
I will also send a first version of the configFS work (two distincts
series to make the review easier).
Thanks a lot,
Louis Chauvet
