Hi, > > > + guc_warn(guc, "excessive init time: [freq = %dMHz -> %dMHz vs %dMHz, perf_limit_reasons = 0x%08X]\n", > > > + before_freq, intel_rps_read_actual_frequency(>->rps), > > > + intel_rps_get_requested_frequency(>->rps), > > While, <value> -> <value> is clear to me if I were to encounter > > this type of log, I wonder if it would be apparent what "vs" > > means here without having to look into the code. Maybe it would > > be worth to add "vs actual:" or ", actual:" instead? > Are you meaning to swap the actual and requested values around? Changing it > to "<before> -> <requested>, actual <actual>" would make it more confusing, > IMHO. > > The print is '<before> -> <actual> vs <requested>', i.e. "it started <here> > and went <there> compared to what we asked for which was <this>". That seems > like the logical order and description to me. The line is already fairly > long so the idea was not to make it any longer than necessary while still > giving all the useful information in a sensible manner. Fair enough. If the line length is a concern, then there is not much that can be done. A good addition overall. Reviewed-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx> Krzysztof
