On Thu, Jan 16, 2025 at 03:26:00PM +0800, Jun Nie wrote: > Split the PIPES_PER_STAGE definition per plane and mixer pair. Why are you trying to repeat commit subject? I noticed this pattern in other patches too. > Currently, 2 pipes are supported for a plane at most. A stage struct > contains configuration for a mixer pair, so pipes per stage are > identical to pipes per plane in this case. More pipes will be required > for the quad-pipe case in the future, and pipes per stage will be > different from pipes per plane in this case. So pipes per plane is > split out as PIPES_PER_PLANE. The stage contains configuration for a mixer pair. Currently the plane supports just one stage and 2 pipes. Quad-pipe support will require handling 2 stages and 4 pipes at the same time. In preparation for that add a separate define, PIPES_PER_PLANE, to denote number of pipes that can be used by the plane. With that being used as a commit message: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Please use this as an example of what is expected from the commit messages. -- With best wishes Dmitry
