Il 14/01/25 06:49, Paul-pl Chen (陳柏霖) ha scritto:
Hi Rob
Thanks for the advice.
The root cause of the erroneous log message is due to missing power/clock dependencies.
Once the MTK clock/power header file is upstreamed,
The mt8196-clk/power.h filenames are anyway wrong for upstream.... :-)
Cheers,
Angelo
we will include a reference link in the next version of the upstream series submission.
Best, Paul-pl Chen
-----Original Message-----
From: Rob Herring (Arm) <robh@xxxxxxxxxx>
Sent: Friday, January 10, 2025 9:54 PM
To: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@xxxxxxxxxxxx>
Cc: conor+dt@xxxxxxxxxx; Singo Chang (張興國) <Singo.Chang@xxxxxxxxxxxx>; Sunny Shen (沈姍姍) <Sunny.Shen@xxxxxxxxxxxx>; chunkuang.hu@xxxxxxxxxx; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@xxxxxxxxxxxx>; fshao@xxxxxxxxxxxx; Sirius Wang (王皓昱) <Sirius.Wang@xxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; matthias.bgg@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Xiandong Wang (王先冬) <Xiandong.Wang@xxxxxxxxxxxx>; treapking@xxxxxxxxxxxx; Nancy Lin (林欣螢) <Nancy.Lin@xxxxxxxxxxxx>; linux-mediatek@xxxxxxxxxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; Jason-JH Lin (林睿祥) <Jason-JH.Lin@xxxxxxxxxxxx>; AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; krzk+dt@xxxxxxxxxx
Subject: Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196
External email : Please do not click links or open attachments until you have verified the sender or the content.
On Fri, 10 Jan 2025 20:33:59 +0800, paul-pl.chen wrote:
From: "Paul-pl.Chen" <paul-pl.chen@xxxxxxxxxxxx>
Add mediatek,exdma.yaml to support EXDMA for MT8196.
Signed-off-by: Paul-pl.Chen <paul-pl.chen@xxxxxxxxxxxx>
---
The header used in examples:
#include <dt-bindings/clock/mt8196-clk.h> #include
<dt-bindings/power/mt8196-power.h>
are not upstreamed yet.
It will be sent by related owner soon.
---
.../display/mediatek/mediatek,exdma.yaml | 77 +++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dts:18:18: fatal error: dt-bindings/clock/mt8196-clk.h: No such file or directory
18 | #include <dt-bindings/clock/mt8196-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250110123835.2719824-5-paul-pl.chen@xxxxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
