Re: [PATCH v3 0/4] Display enablement changes for Qualcomm QCS8300 platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2025/1/13 17:36, Dmitry Baryshkov wrote:
On Mon, Jan 13, 2025 at 05:26:56PM +0800, Yongxing Mou wrote:


On 2025/1/13 17:02, Dmitry Baryshkov wrote:
On Mon, Jan 13, 2025 at 04:03:07PM +0800, Yongxing Mou wrote:
This series introduces support to enable the Mobile Display Subsystem (MDSS)
, Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
QCS8300 target. It includes the addition of the hardware catalog, compatible
string, and their YAML bindings.

Signed-off-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx>
---
Changes in v3:Fixed review comments from Krzysztof, Dmitry.
- Fix the missing space issue in commit message.[Krzysztof]
- Separate the patch for the phy from this series.[Dmitry]
- Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
- Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@xxxxxxxxxxx

Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
- Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
- Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
- Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
- Correct formatting errors and remove unnecessary status in MDSS
    bindings.[Krzysztof]
- Add the the necessary information in MDSS changes commit msg.[Dmitry]
- Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
    20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@xxxxxxxxxx/.[Dmitry]
- Package the DisplayPort controller and eDP PHY bindings document to
    this patch series.
- Collecting MDSS changes reviewd-by Dmitry.
- Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
- Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
- Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@xxxxxxxxxxx
~

---
Yongxing Mou (4):
        dt-bindings: display/msm: Document the DPU for QCS8300
        dt-bindings: display: msm: dp-controller: document QCS8300 compatible
        dt-bindings: display/msm: Document MDSS on QCS8300

Is there any reason for not using a common style for these three
commits?

Hi,actually, for the dp-controller.yamel file, I just noticed that the
previous platforms added the dt-binding files using this format. So, I
followed their format to write the commit message. Such as dt-bindings for
sm8650/sm8150/sm8250...

I don't care about either of the formats, but please be self-consistent.
If one patch out of three has a different subject prefix, that looks
strange.

Got it, it does seem that way. I will revise the commit message format in the next version along with the MDSS binding review comments. Thanks.
        drm/msm: mdss: Add QCS8300 support

   .../bindings/display/msm/dp-controller.yaml        |   4 +
   .../bindings/display/msm/qcom,qcs8300-mdss.yaml    | 244 +++++++++++++++++++++
   .../bindings/display/msm/qcom,sm8650-dpu.yaml      |  13 +-
   drivers/gpu/drm/msm/msm_mdss.c                     |  11 +
   4 files changed, 268 insertions(+), 4 deletions(-)
---
base-commit: 2b88851f583d3c4e40bcd40cfe1965241ec229dd
change-id: 20241224-mdssdt_qcs8300-11b7883dc60b

Best regards,
--
Yongxing Mou <quic_yongmou@xxxxxxxxxxx>








[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux