On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
dsi_clk_init() and msm_dsi_host_init() are called only from platform
dsi_get_config() as well? OR you didnt want to explicitly mention that since its called from msm_dsi_host_init().
driver probe function, so using dev_err_probe is both appropriate and beneficial: - Properly marks device deferred probe status, - Avoids dmesg flood on probe deferrals, - Already incorporates printing ERR value, - Shows device name (in contrast to pr_err()), - Makes code smaller and simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 100 +++++++++++++++---------------------- 1 file changed, 41 insertions(+), 59 deletions(-)
Change LGTM, Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
