On Thu, Jan 02, 2025 at 09:04:47AM +0000, Jesse Van Gavere wrote: > Hello Dmitry, > > ... > > > The atomic_check() function verifies if the passed set of changes (in the form of drm_*_state) is valid from the driver's point of view. If you have nothing to check, it's fine to skip the function. > > ... > > Perhaps one last question on the use of atomic_check, this function is > needed for TIDSS so I got to implement something either way. How is it so? I don't see any specific requirements on the TIDSS side. > Currently I just have an empty function returning 0 there. > So I looked for something better and stumbled upon your usage of the drm_atomic_helper_connector_hdmi_check function > in this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/bridge/lontium-lt9611.c?id=ac4627c304e7a09068d0e2dba34d21e492649f8d > > Would this be a good candidate for the atomic_check in adv7511 as well > if I pair it with implementing the additional necessary bridge funcs > (char rate valid, infoframe R/W)? I think that's a separate topic. Bridge drivers don't have to implement atomic_check. In fact, if you check the latest LT9611 driver, it has dropped the .atomic_check() completely, as the corresponding HDMI-state check function is supposed to be called by the connector code (e.g. drm_bridge_connector_atomic_check() calls it). Regarding the conversion of the adv7511 driver to using HDMI callbacks. This has been on my todo list, but I'd rather land HDMI Codec and generic CEC patches first. > Thank you for your help. > > Best regards, > Jesse -- With best wishes Dmitry
