Hello Dmitry, > The atomic_check() function verifies if the passed set of changes (in the form of drm_*_state) is valid from the driver's point of view. If you have nothing to check, it's fine to skip the function. I'll look over the other examples a bit then but I think the reason for implementing it was I thought TIDSS seemed to expect it. > I'd say, it's fine to ommit the output formats handling. From what I can see only dw-hdmi does sensible job of calculating output bus formats for HDMI Bus. The it66121 simply returns MEDIA_BUS_FMT_RGB888_1X24. Yeah the output formats are also not well defined in the ADV75xx docs so I'll best leave that be for now. > No, each bus (DSI, DPI, etc) have it's own data formats. This means > ADV7511 (D[35:0]), ADV7513 (D[23:0]) and ADV7533/35 (4x D-PHY lanes + clock lane) have different input formats. ... > Just uapi patch with explanation and justification. Got it, I'll make inventory of what's all out there first then and send it. > -- > With best wishes > Dmitry Thank you very much for all the information, should really help in writing the first patches to implement this! Best regards, Jesse
