Hi, Arnd: Arnd Bergmann <arnd@xxxxxxxxxx> 於 2024年12月18日 週三 下午4:58寫道： > > From: Arnd Bergmann <arnd@xxxxxxxx> > > The PHY portion of the mediatek hdmi driver was originally part of > the driver it self and later split out into drivers/phy, which a > 'select' to keep the prior behavior. > > However, this leads to build failures when the PHY driver cannot > be built: > > WARNING: unmet direct dependencies detected for PHY_MTK_HDMI > Depends on [n]: (ARCH_MEDIATEK || COMPILE_TEST [=y]) && COMMON_CLK [=y] && OF [=y] && REGULATOR [=n] > Selected by [m]: > - DRM_MEDIATEK_HDMI [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_MEDIATEK [=m] > ERROR: modpost: "devm_regulator_register" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! > ERROR: modpost: "rdev_get_drvdata" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! > > The best option here is to just not select the phy driver and leave that > up to the defconfig. Do the same for the other PHY and memory drivers > selected here as well for consistency. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: a481bf2f0ca4 ("drm/mediatek: Separate mtk_hdmi_phy to an independent module") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/gpu/drm/mediatek/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 1c2f56b75716..1d4f20a4f265 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -15,9 +15,6 @@ config DRM_MEDIATEK > select DRM_BRIDGE_CONNECTOR > select DRM_MIPI_DSI > select DRM_PANEL > - select MEMORY > - select MTK_SMI > - select PHY_MTK_MIPI_DSI > select VIDEOMODE_HELPERS > help > Choose this option if you have a Mediatek SoCs. > @@ -28,7 +25,6 @@ config DRM_MEDIATEK > config DRM_MEDIATEK_DP > tristate "DRM DPTX Support for MediaTek SoCs" > depends on DRM_MEDIATEK > - select PHY_MTK_DP > select DRM_DISPLAY_HELPER > select DRM_DISPLAY_DP_HELPER > select DRM_DISPLAY_DP_AUX_BUS > @@ -39,6 +35,5 @@ config DRM_MEDIATEK_HDMI > tristate "DRM HDMI Support for Mediatek SoCs" > depends on DRM_MEDIATEK > select SND_SOC_HDMI_CODEC if SND_SOC > - select PHY_MTK_HDMI > help > DRM/KMS HDMI driver for Mediatek SoCs > -- > 2.39.5 >
