On 12/21/2024 2:28 AM, Dmitry Baryshkov wrote: > On Fri, Dec 20, 2024 at 08:56:31PM +0100, Konrad Dybcio wrote: >> On 13.12.2024 12:46 PM, Akhil P Oommen wrote: >>> From: Jie Zhang <quic_jiezh@xxxxxxxxxxx> >>> >>> Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. >>> A612 falls under ADRENO_6XX_GEN1 family and is a cut down version >>> of A615 GPU. >>> >>> A612 has a new IP called Reduced Graphics Management Unit or RGMU >>> which is a small state machine which helps to toggle GX GDSC >>> (connected to CX rail) to implement IFPC feature. It doesn't support >>> any other features of a full fledged GMU like clock control, resource >>> voting to rpmh etc. So we need linux clock driver support like other >>> gmu-wrapper implementations to control gpu core clock and gpu GX gdsc. >>> Since there is no benefit with enabling RGMU at the moment, RGMU is >>> entirely skipped in this patch. >>> >>> Signed-off-by: Jie Zhang <quic_jiezh@xxxxxxxxxxx> >>> Signed-off-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> >>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >>> --- >> >> So we talked offline a bit, and the RGMU requires a piece of firmware. >> >> We concluded it's best to describe that from the get-go, so that the >> user doesn't get surprised when a new kernel update brings new firmware >> requirements for previously-working hardware. > > I'd say, please make sure that the RGMU firmware is also a part of the > linux-firmware from the beginning. Yes, I am working on that part. I will send another revision of this patch. -Akhil > >> >> Please wait for the new revision. >> >> Konrad >
