On 19/12/2024 17:05, Karunika Choo wrote: > This patch adds 64-bit register accessors to simplify register access in > Panthor. It also adds 64-bit variants for read_poll_timeout and replaces > all 64-bit and poll register accesses with these new functions. > > Signed-off-by: Karunika Choo <karunika.choo@xxxxxxx> (Minor NIT: This might be easier to review as two patches - one which adds the new functions and a second which switching the code over to use them). [...] > diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h > index b7b3b3add166..269c2c68dde2 100644 > --- a/drivers/gpu/drm/panthor/panthor_regs.h > +++ b/drivers/gpu/drm/panthor/panthor_regs.h > @@ -10,6 +10,9 @@ > #ifndef __PANTHOR_REGS_H__ > #define __PANTHOR_REGS_H__ > > +#include <linux/iopoll.h> > + > +/* GX10 registers */ NIT: Please don't include unrelated changes like this comment. Other than those minor issues, this looks like a nice improvement. Steve
