On 23/12/2024 13:55, Michal Wilczynski wrote: > Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This > controller manages resets for subsystems such as the GPU within the > TH1520 SoC. > > Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > --- > .../bindings/reset/thead,th1520-reset.yaml | 45 +++++++++++++++++++ > MAINTAINERS | 2 + > .../dt-bindings/reset/thead,th1520-reset.h | 13 ++++++ > 3 files changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > create mode 100644 include/dt-bindings/reset/thead,th1520-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > new file mode 100644 > index 000000000000..46d0e6b8c712 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + Drop blank line > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD TH1520 SoC Reset Controller > + > +description: | Do not need '|' unless you need to preserve formatting. > + The T-HEAD TH1520 reset controller is a hardware block that asserts/deasserts > + resets for SoC subsystems. > + > +maintainers: > + - Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - thead,th1520-reset > + ... > RNBD BLOCK DRIVERS > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h > new file mode 100644 > index 000000000000..a4958b2ed710 > --- /dev/null > +++ b/include/dt-bindings/reset/thead,th1520-reset.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2024 Samsung Electronics Co., Ltd. > + * Author: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > + */ > + > +#ifndef _DT_BINDINGS_TH1520_RESET_H > +#define _DT_BINDINGS_TH1520_RESET_H > + > +#define TH1520_RESET_ID_GPU 0 > +#define TH1520_RESET_NUM_IDS 1 Drop the NUM_IDS define. Number is not a binding. But this leads to another question: only one reset? Then reset-cells should be 0. > + > +#endif /* _DT_BINDINGS_TH1520_RESET_H */ Best regards, Krzysztof
