On Mon, Dec 23, 2024 at 02:41:39PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller has a built-in interrupt controller to support > Enable/Status/Preset/Clear interrupt bit. Add driver for it. > > Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx> > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > --- > v7: > * Fix regmap_config definition by removing name field, correcting read ranges > and setting max_register field. > * Collect Maxime's R-b tag. > > v6: > * No change. > > v5: > * Replace .remove_new with .remove in dc-ic.c. (Uwe) > > v4: > * Use regmap to define register map for all registers. (Dmitry) > * Use regmap APIs to access registers. (Dmitry) > * Use devm_kzalloc() to drmm_kzalloc() to allocate dc_ic_data data strutures. > * Set suppress_bind_attrs driver flag to true to avoid unnecessary sys > interfaces to bind/unbind the driver. > * Take DC interrupt controller driver as a standalone driver instead of a > component driver. > * Replace drmm_kcalloc() with devm_kcalloc() to allocate an array for > struct dc_ic_entry. > * Call platform_get_irq() from DC interrupt controller driver to make sure > parent interrupt controller driver is probed first. > > v3: > * No change. > > v2: > * No change. > > drivers/gpu/drm/imx/dc/Kconfig | 1 + > drivers/gpu/drm/imx/dc/Makefile | 2 +- > drivers/gpu/drm/imx/dc/dc-drv.c | 1 + > drivers/gpu/drm/imx/dc/dc-drv.h | 1 + > drivers/gpu/drm/imx/dc/dc-ic.c | 282 ++++++++++++++++++++++++++++++++ > 5 files changed, 286 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/imx/dc/dc-ic.c Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry