On Mon, Dec 16, 2024 at 02:50:13PM +0000, Derek Foreman wrote:
> Just a ping - is there anything further I need to do here?
I expected that the patch should have been reviewed by Maxime. I'll
check if it's okay to push it with Angelo's and mine reviews.
>
> On 2024-12-03 03:45, AngeloGioacchino Del Regno wrote:
> > Il 02/12/24 19:19, Derek Foreman ha scritto:
> > > Our infoframe setting code currently lacks the ability to clear
> > > infoframes. For some of the infoframes, we only need to replace them,
> > > so if an error occurred when generating a new infoframe we would leave
> > > a stale frame instead of clearing the frame.
> > >
> > > However, the Dynamic Range and Mastering (DRM) infoframe should only
> > > be present when displaying HDR content (ie: the HDR_OUTPUT_METADATA blob
> > > is set). If we can't clear infoframes, the stale DRM infoframe will
> > > remain and we can never set the display back to SDR mode.
> > >
> > > With this change, we clear infoframes when they can not, or should not,
> > > be generated. This fixes switching to an SDR mode from an HDR one.
> > >
> > > Fixes: f378b77227bc4 ("drm/connector: hdmi: Add Infoframes generation")
> > > Signed-off-by: Derek Foreman <derek.foreman@xxxxxxxxxxxxx>
> >
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> >
--
With best wishes
Dmitry
