Re: [PATCH v4 02/16] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/16/2024 2:24 PM, Dmitry Baryshkov wrote:
On Mon, Dec 16, 2024 at 11:32:57AM -0800, Abhinav Kumar wrote:


On 12/15/2024 2:44 PM, Dmitry Baryshkov wrote:
Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly
to program audio packet data. Use 0 as Packet ID, as it was not
programmed earlier.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
   drivers/gpu/drm/msm/dp/dp_audio.c   | 268 ++++++------------------------------
   drivers/gpu/drm/msm/dp/dp_catalog.c |  71 ++++++++++
   drivers/gpu/drm/msm/dp/dp_catalog.h |  10 ++
   3 files changed, 122 insertions(+), 227 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b/drivers/gpu/drm/msm/dp/dp_audio.c
index 5cbb11986460d1e4ed1890bdf66d0913e013083c..46fbf8601eea8e43a152049dfd1dc1d77943d922 100644
--- a/drivers/gpu/drm/msm/dp/dp_audio.c
+++ b/drivers/gpu/drm/msm/dp/dp_audio.c
@@ -14,6 +14,7 @@
   #include "dp_catalog.h"
   #include "dp_audio.h"
   #include "dp_panel.h"
+#include "dp_reg.h"

This change still does reg writes through catalog. Why do you need to
include dp_reg.h here?

A leftover from the previous patchset.

Feel free to add my

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

Once this include is dropped.



   #include "dp_display.h"
   #include "dp_utils.h"




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux