On Fri, 13 Dec 2024, Imre Deak <imre.deak@xxxxxxxxx> wrote: > On Thu, Dec 12, 2024 at 12:12:15PM +0200, Jani Nikula wrote: >> On Thu, 12 Dec 2024, Imre Deak <imre.deak@xxxxxxxxx> wrote: >> > MST connectors should be initialized/registered by calling >> > drm_connector_dynamic_init()/drm_connector_dynamic_register(). The >> > previous patch adding these functions explains the issue with the >> >> References to "previous patch" become meaningless after this has been >> committed. > > Ok, will change it to: "The patch adding these functions ...". In 99% cases having the word "patch" in a commit message is just wrong... BR, Jani. > >> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> >> > current drm_connector_init*()/drm_connector_register() interface for >> > MST connectors. >> > >> > Based on the above adjust here the registration part and change the >> > initialization part in follow-up patches for each driver. >> > >> > For now, drivers are allowed to keep using the drm_connector_init*() >> > functions, by drm_connector_dynamic_register() checking for this (see >> > drm_connector_add()). A patch later will change this to WARN in such >> > cases. >> > >> > Cc: Lyude Paul <lyude@xxxxxxxxxx> >> > Cc: Harry Wentland <harry.wentland@xxxxxxx> >> > Cc: Leo Li <sunpeng.li@xxxxxxx> >> > Cc: Wayne Lin <wayne.lin@xxxxxxx> >> > Cc: Alex Deucher <alexander.deucher@xxxxxxx> >> > Cc: Karol Herbst <kherbst@xxxxxxxxxx> >> > Cc: Danilo Krummrich <dakr@xxxxxxxxxx> >> > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> >> > --- >> > drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c >> > index 687c70308d82b..f8cd094efa3c0 100644 >> > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c >> > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c >> > @@ -2281,7 +2281,7 @@ drm_dp_mst_port_add_connector(struct drm_dp_mst_branch *mstb, >> > port->cached_edid = drm_edid_read_ddc(port->connector, >> > &port->aux.ddc); >> > >> > - drm_connector_register(port->connector); >> > + drm_connector_dynamic_register(port->connector); >> > return; >> > >> > error: >> >> -- >> Jani Nikula, Intel -- Jani Nikula, Intel
