Re: [PATCH v4 4/7] dt-bindings: display: renesas,du: Add r8a779h0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 16, 2024 at 12:56:09PM +0200, Tomi Valkeinen wrote:
> On 16/12/2024 10:00, Krzysztof Kozlowski wrote:
> > On Fri, Dec 13, 2024 at 04:03:00PM +0200, Tomi Valkeinen wrote:
> >>   
> >> -    required:
> >> -      - port@0
> >> -      - port@1
> >> -
> >>       unevaluatedProperties: false
> >>   
> >>     renesas,cmms:
> >> @@ -817,6 +814,54 @@ allOf:
> >>           - reset-names
> >>           - renesas,vsps
> >>   
> >> +  - if:
> >> +      properties:
> >> +        compatible:
> >> +          contains:
> >> +            enum:
> >> +              - renesas,du-r8a779h0
> >> +    then:
> >> +      properties:
> >> +        clocks:
> >> +          items:
> >> +            - description: Functional clock
> >> +
> >> +        clock-names:
> >> +          items:
> >> +            - const: du.0
> >> +
> >> +        interrupts:
> >> +          maxItems: 1
> >> +
> >> +        resets:
> > 
> > No minItems here...
> > 
> >> +          maxItems: 1
> >> +
> >> +        reset-names:
> >> +          items:
> >> +            - const: du.0
> >> +
> >> +        ports:
> >> +          properties:
> >> +            port@0:
> >> +              description: DSI 0
> >> +            port@1: false
> >> +            port@2: false
> >> +            port@3: false
> >> +
> >> +          required:
> >> +            - port@0
> >> +
> >> +        renesas,vsps:
> >> +          minItems: 1
> > 
> > so drop minItems here as well.
> 
> Ok. I wanted to be consistent with the other vsps entries in the file, 
> so I added both min and max items. But I can drop it.

I'd favour consistency with the other vsps entries, but not enough to
fight over it.

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux