Hi,
On Wed, Dec 4, 2024 at 2:58 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
>
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
>
> While add it, also remove commas after the sentinel entries.
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Liu Ying <victor.liu@xxxxxxx> # ite-it6263.c
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> On Mon, Dec 02, 2024 at 04:50:01PM -0800, Doug Anderson wrote in reply
> to v2:
> > This conflicts with commit dbf7986f8a56 ("drm/bridge: Constify struct
> > i2c_device_id"). Can you rebase, please?
> >
> > Other than that:
> >
> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> It took me a moment to find a tree + branch that contained the
> above mentioned commit. It would be a real time saver if drm-misc-next
> was included in next. At least saying "drm-misc-next" in such a context
> would be helpful, bonus points for mentioning
>
> https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next
Sorry about that! drm-misc-next often feeds linux-next, but not
always. I'll try to remember to be more explicit in the future.
> The changes in this patch compared to v2,
> https://lore.kernel.org/dri-devel/20241202114731.1005549-2-u.kleine-koenig@xxxxxxxxxxxx/:
>
> - Rebased to drm-misc-next, resolving conflicts in
> drivers/gpu/drm/bridge/lontium-lt9611.c
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> drivers/gpu/drm/bridge/ti-sn65dsi86.c
>
> - Applied the R-b tag received for v2.
>
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +-
> drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
> drivers/gpu/drm/bridge/chrontel-ch7033.c | 2 +-
> drivers/gpu/drm/bridge/ite-it6263.c | 2 +-
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 4 ++--
> drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 8 ++++----
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 ++--
> drivers/gpu/drm/bridge/sii902x.c | 4 ++--
> drivers/gpu/drm/bridge/sii9234.c | 4 ++--
> drivers/gpu/drm/bridge/sil-sii8620.c | 4 ++--
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> drivers/gpu/drm/bridge/tc358768.c | 4 ++--
> drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +-
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
> drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
> drivers/gpu/drm/i2c/tda9950.c | 4 ++--
> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> 22 files changed, 33 insertions(+), 33 deletions(-)
Pushed to drm-misc-next:
[1/1] drm: Drop explicit initialization of struct
i2c_device_id::driver_data to 0
commit: b690f5d955e033b9bd80de0486a04adf150f89a8
