On 12/12/2024 10:31 AM, Abhinav Kumar wrote:
On 12/12/2024 12:58 AM, Dmitry Baryshkov wrote:
On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote:
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote:
Rather than printing random garbage from stack and pretending that
it is
the default safe_to_exit_level, set the variable beforehand.
Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port
on MSM")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes:
https://lore.kernel.org/oe-kbuild-all/202411081748.0PPL9MIj-lkp@xxxxxxxxx/
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/dp/dp_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c
b/drivers/gpu/drm/msm/dp/dp_audio.c
index
74e01a5dd4195d5e0e04250663886f1116f25711..5cbb11986460d1e4ed1890bdf66d0913e013083c 100644
--- a/drivers/gpu/drm/msm/dp/dp_audio.c
+++ b/drivers/gpu/drm/msm/dp/dp_audio.c
@@ -329,10 +329,10 @@ static void
msm_dp_audio_safe_to_exit_level(struct msm_dp_audio_private *audio)
safe_to_exit_level = 5;
break;
default:
+ safe_to_exit_level = 14;
drm_dbg_dp(audio->drm_dev,
"setting the default safe_to_exit_level = %u\n",
safe_to_exit_level);
- safe_to_exit_level = 14;
break;
}
This was already picked up in -fixes, so no need to include
I have been rebasing on linux-next. Please make sure that your -fixes
branch is a part of linux-next.
Its merged to msm-fixes not just my fixes branch. I am pretty sure
msm-fixes is part of linux-next.
Actually, I noticed just now that msm-fixes is not part of linux-next.
So pls ignore my comment. drm-fixes is part of linux-next. We should be
sending out our PR pretty soon. So you will be able to drop this after that.
