On Wed, Dec 11, 2024 at 08:46:11AM +0100, Boris Brezillon wrote:
> Calling panthor_sched_suspend() doesn't guarantee that all groups
> are in the idle lists. Only the ones that were currently scheduled
> are handled in panthor_sched_suspend(), and that's fine, because
> we stop all runnable groups in panthor_sched_pre_reset(), but let's
> stop complaining about it.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index 77b184c3fb0c..ed3b46767ed5 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -2809,8 +2809,6 @@ void panthor_sched_pre_reset(struct panthor_device *ptdev)
> * new jobs while we're resetting.
> */
> for (i = 0; i < ARRAY_SIZE(sched->groups.runnable); i++) {
> - /* All groups should be in the idle lists. */
> - drm_WARN_ON(&ptdev->base, !list_empty(&sched->groups.runnable[i]));
> list_for_each_entry_safe(group, group_tmp, &sched->groups.runnable[i], run_node)
> panthor_group_stop(group);
> }
> --
> 2.47.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
